Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ReplaySubject): don't buffer next if stopped #5696

Merged
merged 3 commits into from
Sep 6, 2020

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Sep 5, 2020

Description:

This PR fixes a bug in ReplaySubject - demonstrated in failing tests - in which nexted values were buffered after the subject was stopped (by a complete or error call).

Related issue (if exists): None

@cartant cartant requested a review from benlesh September 5, 2020 11:56
Oh, FFS, now I've done it.
@benlesh benlesh merged commit a08232b into ReactiveX:master Sep 6, 2020
@benlesh
Copy link
Member

benlesh commented Sep 6, 2020

* chore: remove VSCode-added lodash import

Oh, FFS, now I've done it.

🤣

benlesh pushed a commit that referenced this pull request Sep 6, 2020
* test(ReplaySubject): add failing tests

* fix(ReplaySubject): don't buffer next if stopped

* chore: remove VSCode-added lodash import

Oh, FFS, now I've done it.
@benlesh
Copy link
Member

benlesh commented Sep 6, 2020

Merged into master and 6.x

@benlesh
Copy link
Member

benlesh commented Sep 6, 2020

published with 6.6.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants